add leader election mechanism #1285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neil-hickey
reviewed
Aug 15, 2023
cmd/controller/main.go
Outdated
| client *clientset.Clientset | ||
| ) | ||
|
|
||
| func getNewLock(lockname, podname, namespace string) *resourcelock.LeaseLock { |
There was a problem hiding this comment.
Early Feedback: Can we move all the leader election code to a different file / module? Main ought to be as simple as possible (just start the app)
|
Hi @basit9958 , thanks for this! Is this PR intended to be for demonstration / Proof of Concept purposes - or the intended feature complete? If it's intended to be complete, looks like it doesn't compile right now. |
It is meant to be complete, I will fix these errors |
Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
Signed-off-by: Basit Hasan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added Leader Election Mechanism
OnStartedLeading: This callback is executed when the current instance becomes the leader. It starts running the controller logic by calling the Run function.OnStoppedLeading: This callback is executed when the current instance is no longer the leader. It logs a message and may exit gracefully if needed.OnNewLeader: This callback is executed when a new leader is elected. It logs a message indicating the new leader's identity.Which issue(s) this PR fixes:
Fixes #838
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: